Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: domain picker shows domain components in the wrong order in RTL locale #47885

Closed
p-jackson opened this issue Dec 1, 2020 · 1 comment · Fixed by #47889
Closed
Labels
[Goal] New Onboarding previously called Gutenboarding i18n Launch

Comments

@p-jackson
Copy link
Member

Steps to reproduce

  1. Starting at URL: /new/he
  2. Advance to the domain picker
  3. Search for anything

What I expected

  • The domain search should be left aligned (this is how we display domains in input boxes, see /me/account and /start/domains)
  • The search results should show the domain components in the correct order

What happened instead

  • The domain search is right aligned
  • The domain results are displayed broken e.g. if I search for mytestdomain then the result will be wordpress.com.mytestdomain

Screenshot / Video

image

Context / Source

pbAok1-1II-p2#comment-3455

@emilyaudela
Copy link
Contributor

Can you also make sure this is resolved on the "Launch" screen after the site has been created? Also, please note some RTL issues in the domain screen here. It should be aligned in the same way as the gutenboarding flow in the screenshot above.

Screen Shot 2020-12-01 at 11 40 32 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding i18n Launch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants