You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When customer doesn't enter title at intent capture step, we don't potentially have anything for the domain picker to do the search:
Since they filled vertical, we could use that as search term to ensure we have some results:
This is a pretty minor issue, but when I enter non-ASCII symbols in the title (e.g. emoji), the domain picker gets stuck with API response Query parameter must contain alphanumeric characters:
In that case, we can also fire the query with vertical.
I'm not sure it makes sense to fall back to the vertical if the title contains non-alphanumeric characters -- the vertical might be user-specified, too, and thus can also contain non-alphanumeric chars 😅 How about removing the non-alphanum characters from both when looking up domain suggestions?
If site-title isn't alphanumeric, domains API can't return anything apparently. #40770 is sufficient enough for now. I'll mark the rest of the follow-ups as a lower priority.
simison
changed the title
Gutenboarding: handle missing title in domain picker
Gutenboarding: handle non-alphanumeric title in domain picker
Apr 6, 2020
When customer doesn't enter title at intent capture step, we don't potentially have anything for the domain picker to do the search:
Since they filled vertical, we could use that as search term to ensure we have some results:
This is a pretty minor issue, but when I enter non-ASCII symbols in the title (e.g. emoji), the domain picker gets stuck with API response
Query parameter must contain alphanumeric characters
:In that case, we can also fire the query with vertical.
Action items:
The text was updated successfully, but these errors were encountered: