Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: handle non-alphanumeric title in domain picker #40748

Closed
1 of 3 tasks
simison opened this issue Apr 3, 2020 · 5 comments
Closed
1 of 3 tasks

Gutenboarding: handle non-alphanumeric title in domain picker #40748

simison opened this issue Apr 3, 2020 · 5 comments
Assignees
Labels

Comments

@simison
Copy link
Member

simison commented Apr 3, 2020

When customer doesn't enter title at intent capture step, we don't potentially have anything for the domain picker to do the search:

Screenshot 2020-04-03 at 14 07 38

Screenshot 2020-04-03 at 14 08 24

Since they filled vertical, we could use that as search term to ensure we have some results:

Screenshot 2020-04-03 at 14 12 07

This is a pretty minor issue, but when I enter non-ASCII symbols in the title (e.g. emoji), the domain picker gets stuck with API response Query parameter must contain alphanumeric characters:

Screenshot 2020-04-03 at 14 12 07

In that case, we can also fire the query with vertical.

Action items:

@ockham
Copy link
Contributor

ockham commented Apr 3, 2020

I'm not sure it makes sense to fall back to the vertical if the title contains non-alphanumeric characters -- the vertical might be user-specified, too, and thus can also contain non-alphanumeric chars 😅 How about removing the non-alphanum characters from both when looking up domain suggestions?

@ockham
Copy link
Contributor

ockham commented Apr 3, 2020

Maybe I've been misreading you -- did you mean site titles containing only non-alphanumeric characters?

@simison
Copy link
Member Author

simison commented Apr 6, 2020

If site-title isn't alphanumeric, domains API can't return anything apparently. #40770 is sufficient enough for now. I'll mark the rest of the follow-ups as a lower priority.

@simison simison changed the title Gutenboarding: handle missing title in domain picker Gutenboarding: handle non-alphanumeric title in domain picker Apr 6, 2020
@yansern
Copy link
Contributor

yansern commented Aug 13, 2020

I'd like to reserve this as one of the good first issue for @ciampo! Thanks!

@razvanpapadopol razvanpapadopol assigned yansern and unassigned ockham Jan 27, 2021
@yansern
Copy link
Contributor

yansern commented Feb 26, 2021

This is fixed in #48031 and #48399.

@yansern yansern closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants