Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(5P) SPT: stop Modal accidentally closing #35599

Closed
getdave opened this issue Aug 20, 2019 · 2 comments
Closed

(5P) SPT: stop Modal accidentally closing #35599

getdave opened this issue Aug 20, 2019 · 2 comments
Assignees
@getdave
Labels
[Goal] Full Site Editing [Goal] Page Templates
Milestone
Ajax: Iteration 7

Comments

@getdave
Copy link
Contributor

getdave commented Aug 20, 2019

Currently, the Modal appears to randomly lose focus and close itself.

Steps to reproduce

  1. Open new Page
  2. See Template selector Modal overlay
  3. Click on one of the Templates to focus and display the large preview
  4. Switch to another application or program (eg: Slack)
  5. Switch back to your browser.
  6. See the Modal has auto-closed.

What I expected

The Modal to still be open when returning to the Page.

What happened instead

The Modal had been auto-closed without any explicit user interaction

Browser / OS version

Chrome, Firefox (probably all of them!)
@getdave getdave added this to the Ajax: Iteration 7 milestone Aug 20, 2019
@getdave getdave self-assigned this Aug 20, 2019
@getdave
Copy link
Contributor Author

getdave commented Aug 20, 2019

It was discovered that the Modal was closing due to the window/document no longer having focus.

This is addressed at

WordPress/gutenberg#17051

@getdave getdave changed the title SPT: stop Modal accidentally closing (5P) SPT: stop Modal accidentally closing Aug 20, 2019
@getdave
Copy link
Contributor Author

getdave commented Aug 20, 2019 •
edited
Loading

This will be "fixed" once this PR is released to the Gutenberg Plugin.

@getdave getdave closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Goal] Full Site Editing [Goal] Page Templates
Projects
None yet
Milestone
Ajax: Iteration 7
Development

No branches or pull requests
1 participant
@getdave