Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Implement Media Modal #21302

Closed
justinshreve opened this issue Jan 5, 2018 · 2 comments
Closed

Store: Implement Media Modal #21302

justinshreve opened this issue Jan 5, 2018 · 2 comments

Comments

@justinshreve
Copy link
Contributor

Right now, Store on WordPress.com uses a simple upload component to upload images. Part of the original designs intended to use the media modal, but we left it out of the initial implementation.

I dug down the rabbit hole again to see how difficult it would be to implement the modal now. It looks like we have some "prior art" now with site icon management (https://wordpress.com/settings/general/:site), which I don't believe existed before.

The site icon implements post-editor/media-modal which works OK for selecting a single image, but if you try to allow multiple item selection, the modal takes you through gallery settings and some other screens which are not really applicable outside of the post context.

I think we could role our own media modal component that implements MediaLibrary, and keeps us out of some of the views we don't want. We can also make it return selected image data in a form that's more useful for passing to WooCommerce API endpoints.

Related: #14760.

@justinshreve
Copy link
Contributor Author

justinshreve commented Jan 5, 2018

I think this will take a bit of work (probably a few days to get working as a replacement), so I'm still going to implement product categories the way we have product images implemented right now. But I wanted to log this as a potential improvement that we might want to tackle down the road as a replacement for the current component.

@stale
Copy link

stale bot commented Apr 8, 2019

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Apr 8, 2019
@stale stale bot closed this as completed Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants