You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The changes introduced in #1565 (comment) don't work well at window sizes between about 660 and 760. One solution to this would be to add a new breakpoint at about 760 pixels, but since this is a big change I wanted to move the discussion to a new issue (this one!). I'll post a follow up PR with a suggestion.
I'm not sure we need to introduce a new breakpoint, especially since the length of the text and the description may vary drastically depending on the user's language. This might actually just require some tweaking of the flexbox layout so the Purchase Now button moves to the bottom in that case.
I spent a bit of time coming up with a solution to this in #1565. The issue with 'Purchase Now' overflowing screenshot above can't be reproduced anymore, and the CTA buttons are all compact now (screenshot).
I'm going to close this as fixed. Feel free to open if anyone thinks this fix isn't adequate, but if any issue still exists, I think it is slight enough to belong in the v2 milestone now.
The changes introduced in #1565 (comment) don't work well at window sizes between about 660 and 760. One solution to this would be to add a new breakpoint at about 760 pixels, but since this is a big change I wanted to move the discussion to a new issue (this one!). I'll post a follow up PR with a suggestion.
I'll move forward with this when #1565 is merged.
The text was updated successfully, but these errors were encountered: