Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free trials: Mobile styles between 660 and 960 pixels #1685

Closed
scruffian opened this issue Dec 16, 2015 · 2 comments
Closed

Free trials: Mobile styles between 660 and 960 pixels #1685

scruffian opened this issue Dec 16, 2015 · 2 comments

Comments

@scruffian
Copy link
Member

The changes introduced in #1565 (comment) don't work well at window sizes between about 660 and 760. One solution to this would be to add a new breakpoint at about 760 pixels, but since this is a big change I wanted to move the discussion to a new issue (this one!). I'll post a follow up PR with a suggestion.

screenshot 2015-12-16 13 37 19

I'll move forward with this when #1565 is merged.

@scruffian scruffian self-assigned this Dec 16, 2015
@scruffian scruffian added this to the No-cc Free Trials: v1 milestone Dec 16, 2015
@stephanethomas
Copy link
Contributor

I'm not sure we need to introduce a new breakpoint, especially since the length of the text and the description may vary drastically depending on the user's language. This might actually just require some tweaking of the flexbox layout so the Purchase Now button moves to the bottom in that case.

@drewblaisdell
Copy link
Contributor

I spent a bit of time coming up with a solution to this in #1565. The issue with 'Purchase Now' overflowing screenshot above can't be reproduced anymore, and the CTA buttons are all compact now (screenshot).

I'm going to close this as fixed. Feel free to open if anyone thinks this fix isn't adequate, but if any issue still exists, I think it is slight enough to belong in the v2 milestone now.

@scruffian scruffian removed their assignment Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants