Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Credit and Debit radio button label in checkout #9660

Open
pierorocca opened this issue Oct 31, 2024 · 4 comments · May be fixed by #9769
Open

Update the Credit and Debit radio button label in checkout #9660

pierorocca opened this issue Oct 31, 2024 · 4 comments · May be fixed by #9769
Assignees
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: enhancement The issue is a request for an enhancement.

Comments

@pierorocca
Copy link
Contributor

pierorocca commented Oct 31, 2024

Description

In #9625 (comment) @frosso points out that on mobile sized viewports, e.g. 375px wide, the Test badge wraps.

While this is not overly problematic, making choices that are mobile friendly particularly space efficiency, is an important principle to follow. The two options considered were:

  1. "Credit / debit card" - this aligns with the latest copy in the merchant settings UI.
  2. "Cards" - this was suggested by Daniel in design as the most space efficient option.

Option 2 is the most compelling as it's the most space efficient and opens up room for the new responsive logos seen in v2 and that we'll implement in v1 once Stripe unblocks us. The generic card icon present is temporary and will be replaced by the end of 2024. Cards + card brand logos, currently in the card number field and later will be moved to the radio button, is more than sufficient to let the user know the payment method type.

Acceptance criteria

  1. The Card component radio button label on shortcode and blocks checkout is "Cards".

  2. Decouple (if it really is coupled) and update the settings UI text to "Credit / Debit Cards". This should be plural since it's titling the category consisting of many card brands and types vs. a user entering a single card in checkout where the singular form made sense. Also it looks a bit odd that "card" is the only word in the entire list of payment methods that's lower case. I know normally we use sentence case but in this instance use title case.
    Image

No other changes to the Test Mode badge or the generic card icon are required at this time.

@pierorocca pierorocca added focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement. labels Oct 31, 2024
@gpressutto5 gpressutto5 self-assigned this Nov 20, 2024
@gpressutto5
Copy link
Contributor

Hi @pierorocca, could confirm this is what we want?

Details

Image
Image
Image
Image

@pierorocca
Copy link
Contributor Author

Temporarily, yes until we're able to replace the generic icon with the new logos implemented in v2. Could we hold off merging until I get the latest update from Stripe on removal of the animation from the card element?
Image

On the merchant settings UI capitalize "Card" and change it to the plural "Credit / Debit Cards". Otherwise "cards" is the only non capitalized word in the entire payment method list.

@gpressutto5 gpressutto5 linked a pull request Nov 20, 2024 that will close this issue
6 tasks
@gpressutto5
Copy link
Contributor

Will we keep the label "Cards" when we start using the new logos. If so, we can keep the existing PR because that issue is larger and should have its own card. We can still hold this PR so we merge both together even if they're separate.

@pierorocca
Copy link
Contributor Author

Yes so we can fit more logos and the Test badge without crowding on mobile. FYI Stripe gated our dev account today with the removal of the animation. So I think we're good to move forward with applying the v2 radio button logos to v1.

@FangedParakeet FangedParakeet added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants