-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for allowedShippingCountries in Express Checkout Element #9104
Comments
Hey team! Please add your planning poker estimate with Zenhub @asumaran @cesarcosta99 @lovo-h @rafaelzaleski @reykjalin @ricardo |
@bborman22 I found a bug while working on this. I tried debugging it without getting too much info about it as it originates on the Stripe library. The issue occurs when a shipping address from a country without shipping options defined is selected. If the address is selected, the payment sheet is closed, the page is refreshed, and then the Google Pay button is clicked, the error is thrown in the browser console.
This is an existing bug, so it is unrelated to the |
I can confirm the same error happens with Apple Pay. edit: If we go to the Checkout page and the addres is changed from the address that has no shipping options to an address that has shipping options defined then Apple Pay/Google Pay works again. |
Yep that is perfect, let's get an issue captured for it and we'll pull into our maintenance rotation, thanks! |
@bborman22 issue created: #9593 |
@bborman22, just to confirm, this should apply to all areas where ECE can be used, correct? That includes the Product Page, Cart Page, Checkout Page, Cart shortcode, Checkout shortcode, and Pay for Order page. This will require extensive testing, so I’m going to revise my original estimate, as I initially thought it was only needed for the Cart and Checkout pages. Additionally, I foresee potential issues with the Pay for Order page if we introduce |
@bborman22 I just noticed we don't ask for shipping details on the "Pay for Order" page.
so this issue won’t impact that page. Please disregard my previous comment. |
Description
With the Express Checkout Element from Stripe (ECE), there is an option to provide an allowedShippingCountries parameter when clicking the element. We can retrieve a list of available countries from the merchant settings to provide to this parameter. This enhancement would make the experience smoother for the shopper in a case where some countries they may have saved aren't allowed by the merchant.
Acceptance criteria
Designs
Testing instructions
Dev notes
Additional context
pcJe93-4x9-p2#comment-4622
The text was updated successfully, but these errors were encountered: