Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-Currency: Fix WooCommerce hook comment phpcs reports #8550

Open
Tracked by #8437
reykjalin opened this issue Apr 1, 2024 · 0 comments
Open
Tracked by #8437

Multi-Currency: Fix WooCommerce hook comment phpcs reports #8550

reykjalin opened this issue Apr 1, 2024 · 0 comments
Labels
focus: multi-currency priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: documentation This issue is a request for better documentation. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@reykjalin
Copy link
Contributor

Part of #8437.

Description

Remove all the WooCommerce.Commenting excludes from phpcs.xml.dist and fix the issues reported when running npm run lint:php in the following files:

  • includes/multi-currency/CurrencySwitcherWidget.php
  • includes/multi-currency/Geolocation.php
  • includes/multi-currency/Analytics.php
  • includes/multi-currency/Compatibility.php
  • includes/multi-currency/Compatibility/WooCommerceProductAddOns.php
  • tests/unit/multi-currency/compatibility/test-class-woocommerce-subscriptions.php
  • includes/multi-currency/MultiCurrency.php
  • includes/multi-currency/StorefrontIntegration.php
@reykjalin reykjalin added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves the technical debt of the project. type: documentation This issue is a request for better documentation. focus: multi-currency labels Apr 1, 2024
@reykjalin reykjalin mentioned this issue Apr 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: multi-currency priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: documentation This issue is a request for better documentation. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reykjalin