Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disputes: fix WordPress.Security phpcs reports #8471

Closed
Tracked by #8434
vbelolapotkov opened this issue Mar 26, 2024 · 1 comment · Fixed by #8478
Closed
Tracked by #8434

Disputes: fix WordPress.Security phpcs reports #8471

vbelolapotkov opened this issue Mar 26, 2024 · 1 comment · Fixed by #8478
Assignees
@nagpai
Labels
focus: disputes priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: has pr The issue has a PR. type: technical debt This issue/PR represents/solves the technical debt of the project.
Milestone
Helix WooPayments...

Comments

@vbelolapotkov
Copy link
Collaborator

vbelolapotkov commented Mar 26, 2024 •
edited
Loading

Part of #8434

Check and fix reports in the following files:

  • includes/core/server/request/class-list-disputes.php
@vbelolapotkov vbelolapotkov mentioned this issue Mar 26, 2024
Closed
@vbelolapotkov vbelolapotkov added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project. focus: disputes labels Mar 26, 2024
@nagpai
Copy link
Contributor

nagpai commented Mar 26, 2024

Error found in log

FILE: <my local path>/woocommerce-payments/includes/core/server/request/class-list-disputes.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 137 | ERROR | All output should be run through an escaping function (see the Security sections in the
     |       | WordPress Developer Handbooks), found '__'.
     |       | (WordPress.Security.EscapeOutput.ExceptionNotEscaped)
--------------------------------------------------------------------------------------------------------

@nagpai nagpai self-assigned this Mar 26, 2024
@nagpai nagpai mentioned this issue Mar 26, 2024
Merged
6 tasks
@nagpai nagpai added the status: has pr The issue has a PR. label Mar 26, 2024
@Jinksi Jinksi added this to the Helix WooPayments 7.5 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nagpai nagpai

Labels
focus: disputes priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: has pr The issue has a PR. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
Helix WooPayments 7.5
Development

Successfully merging a pull request may close this issue.

Disputes: Address new PHPCS error Automattic/woocommerce-payments
3 participants
@vbelolapotkov @Jinksi @nagpai