Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create E2E tests for card testing prevention mitigations #8163

Closed
tpaksu opened this issue Feb 9, 2024 · 1 comment · Fixed by #8164
Closed

Create E2E tests for card testing prevention mitigations #8163

tpaksu opened this issue Feb 9, 2024 · 1 comment · Fixed by #8164
Assignees
@tpaksu
Labels
category: e2e Issues and PRs related to e2e tests. component: card testing Issues related to card testing status: has pr The issue has a PR. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@tpaksu
Copy link
Contributor

tpaksu commented Feb 9, 2024 •
edited
Loading

Description

We need some tests to ensure our card testing mitigation doesn't prevent legit customers don't get their payments blocked because of some error in the mitigation code.

Activating of the meta possibly will be achieved via mocking the account data.

Acceptance criteria

The code will test that when the preventions are enabled:

  • Regular payments are still working as expected
  • Saved card payments are still working as expected
  • Payments with LPM's are still working as expected
  • Payments with ApplePay/GooglePay is still working as expected
  • Payments with WooPay is still working as expected

Designs

Testing instructions

See tests\e2e\README.md for running E2E tests on your local. Also GH E2E actions shall complete without errors.

Dev notes

Something like this was required since the mitigations were implemented, but didn't have an issue defined. After developing #8141 and fixing paJDYF-c8j-p2 showed that it is needed.
@tpaksu tpaksu added type: technical debt This issue/PR represents/solves the technical debt of the project. category: e2e Issues and PRs related to e2e tests. category: devops Features and tools supporting dev process. component: card testing Issues related to card testing and removed category: devops Features and tools supporting dev process. labels Feb 9, 2024
@tpaksu tpaksu mentioned this issue Feb 9, 2024
Merged
6 tasks
@tpaksu tpaksu linked a pull request Feb 9, 2024 that will close this issue
Add E2E tests for card testing mitigation measures #8164
Merged
6 tasks
@tpaksu tpaksu added the status: has pr The issue has a PR. label Feb 9, 2024
@tpaksu tpaksu self-assigned this Feb 9, 2024
@zmaglica
Copy link
Contributor

I have noticed that you are working on this issue @tpaksu . I will move it to the Other Teams queue as a part of the Gamma triage process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpaksu tpaksu

Labels
category: e2e Issues and PRs related to e2e tests. component: card testing Issues related to card testing status: has pr The issue has a PR. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add E2E tests for card testing mitigation measures Automattic/woocommerce-payments
2 participants
@tpaksu @zmaglica