Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the deactivate Woo Subscriptions plugin notice #7240

Closed
james-allan opened this issue Sep 20, 2023 · 1 comment · Fixed by #7323
Closed

Update the deactivate Woo Subscriptions plugin notice #7240

james-allan opened this issue Sep 20, 2023 · 1 comment · Fixed by #7323
Labels
category: core WC Payments core related issues, where it’s obvious. component: wcpay subscriptions Issues related to Stripe Billing Subscriptions type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@james-allan
Copy link
Contributor

Describe the bug

When you deactivate the Woo Subscriptions plugin, the following notice is shown if:

  1. The new Stripe Billing feature is enabled or,
  2. The store has at least 1 Stripe Billing subscription.

Note

This logic is not by original design. With the recent change to load Stripe Billing integration code when the store has enabled the feature, has at least 1 stripe billing or is using the WCPay Subscriptions feature means that this notice is shown when deactivating Woo Subscriptions when it shouldn't.

Important

It use to show if you deactivated Woo Subscriptions and had the WCPay Subscriptions feature enabled.

This notice needs to be updated to:

  1. Show when the store has Stripe Billing Subscriptions.
  2. Refer to the dangers of deactivating Woo Subscriptions while there are Stripe Billing subscriptions.

There's also a weird bug if you have WooCommerce.com connected, clicking the deactivate button doesn't show the notice because the button has an ID of deactivate-woocommerce-com-woocommerce-subscriptions. Which means the code which intercepts the deactivate button click doesn't work.

To Reproduce

  1. Install Woo Subscriptions.
  2. Enable Stripe Billing.
  3. Purchase a subscription using Stripe Billing.
  4. Deactivate Woo Subscriptions.

You should see a notice that warns about the risks of that.

@james-allan james-allan added type: bug The issue is a confirmed bug. type: task The issue is an internally driven task (e.g. from another A8c team). component: wcpay subscriptions Issues related to Stripe Billing Subscriptions labels Sep 20, 2023
@james-allan james-allan removed the type: bug The issue is a confirmed bug. label Sep 20, 2023
@zmaglica zmaglica added the category: core WC Payments core related issues, where it’s obvious. label Sep 25, 2023
@zmaglica
Copy link
Contributor

This issue impacts subscriptions, so assigning to team Quark. (based on team responsibilities Pc2DNy-3z-p2) @diegocurbelo . Assigning as part of Gamma Triage process PcreKM-yM-p2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. component: wcpay subscriptions Issues related to Stripe Billing Subscriptions type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
2 participants