Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit all subscriptions operations when site is in Safe mode #5555

Open
haszari opened this issue Feb 14, 2023 · 2 comments
Open

Inhibit all subscriptions operations when site is in Safe mode #5555

haszari opened this issue Feb 14, 2023 · 2 comments
Labels
category: core WC Payments core related issues, where it’s obvious. component: wcpay subscriptions Issues related to Stripe Billing Subscriptions focus: subscriptions type: bug The issue is a confirmed bug.

Comments

@haszari
Copy link
Contributor

haszari commented Feb 14, 2023

Describe the bug

See also related report #5384

WCPay has a safe mode which kicks in when multiple sites are connecting to the same WCPay account.

WCPay Subscriptions are stored in Stripe (i.e. in WCPay backend). Any actions that change or edit or delete subscriptions should not be attempted on a site in safe mode.

The goal of this issue is to check for safe mode and prevent lossy actions from firing. This will reduce the chance of an accidental or duplicate site breaking subscriptions on the production / primary site.

To Reproduce

Details TBD. Here's a rough overview (I have not tested this)

  • Set up a Woo site with WCPay and WCPay Subscriptions enabled.
  • Back up the site/database and restore on another host or development environment.
  • WCPay safe mode should kick in – the site is a suspected duplicate of a production site.
  • Any subscription actions will potentially affect subscriptions from production site. For example:
    • Cancel a subscription on dev site or delete a user.
    • Change payment method for a subscription.
    • Upgrade or downgrade a subscription.
    • 🚨 Any of these actions could affect subscriptions from the production site.

Screenshots

Expected behavior

Any destructive actions, or actions that change production data, should be disabled in safe mode.

@haszari haszari added type: bug The issue is a confirmed bug. component: wcpay subscriptions Issues related to Stripe Billing Subscriptions labels Feb 14, 2023
@zmaglica
Copy link
Contributor

@haszari is this issue on team Helix's radar? I am triaging the WC Pay backlog, and I am not certain if you are going to handle it.

@zmaglica zmaglica added the category: core WC Payments core related issues, where it’s obvious. label Feb 16, 2023
@haszari
Copy link
Contributor Author

haszari commented Feb 16, 2023

I am triaging the WC Pay backlog, and I am not certain if you are going to handle it.

@zmaglica it's in our maintenance backlog yes, though no specific ETA or commitment to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. component: wcpay subscriptions Issues related to Stripe Billing Subscriptions focus: subscriptions type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants