From ebee3fefa45195fc68f933c1d406b360a86ca95f Mon Sep 17 00:00:00 2001 From: Rua Haszard Date: Tue, 30 Apr 2024 09:03:56 +1200 Subject: [PATCH] tweak emoji survey prompt - "these", was "those" (#8725) Co-authored-by: Rua Haszard Co-authored-by: Eric Jinks <3147296+Jinksi@users.noreply.github.com> --- changelog/fix-8724-are-these-metrics | 5 +++++ client/components/payment-activity/survey/index.tsx | 2 +- .../survey/test/__snapshots__/index.test.tsx.snap | 4 ++-- .../components/payment-activity/survey/test/index.test.tsx | 2 +- .../payment-activity/test/__snapshots__/index.test.tsx.snap | 2 +- client/components/payment-activity/test/index.test.tsx | 4 ++-- 6 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 changelog/fix-8724-are-these-metrics diff --git a/changelog/fix-8724-are-these-metrics b/changelog/fix-8724-are-these-metrics new file mode 100644 index 00000000000..a0c2f5aa55d --- /dev/null +++ b/changelog/fix-8724-are-these-metrics @@ -0,0 +1,5 @@ +Significance: patch +Type: fix +Comment: This is covered by emoji survey changelog from #8506 + + diff --git a/client/components/payment-activity/survey/index.tsx b/client/components/payment-activity/survey/index.tsx index 0067159ff18..cb2bd8abe16 100644 --- a/client/components/payment-activity/survey/index.tsx +++ b/client/components/payment-activity/survey/index.tsx @@ -99,7 +99,7 @@ const Survey: React.FC = () => {
{ __( - 'Are those metrics helpful?', + 'Are these metrics helpful?', 'woocommerce-payments' ) } diff --git a/client/components/payment-activity/survey/test/__snapshots__/index.test.tsx.snap b/client/components/payment-activity/survey/test/__snapshots__/index.test.tsx.snap index aacb8aa6f5f..571ede8a94e 100644 --- a/client/components/payment-activity/survey/test/__snapshots__/index.test.tsx.snap +++ b/client/components/payment-activity/survey/test/__snapshots__/index.test.tsx.snap @@ -13,7 +13,7 @@ exports[`WcPayOverviewSurveyContextProvider test survey initial display 1`] = `
- Are those metrics helpful? + Are these metrics helpful?
@@ -92,7 +92,7 @@ exports[`WcPayOverviewSurveyContextProvider test survey with comments textbox 1`
- Are those metrics helpful? + Are these metrics helpful?
diff --git a/client/components/payment-activity/survey/test/index.test.tsx b/client/components/payment-activity/survey/test/index.test.tsx index 1b6ffef0147..35554f33340 100644 --- a/client/components/payment-activity/survey/test/index.test.tsx +++ b/client/components/payment-activity/survey/test/index.test.tsx @@ -53,7 +53,7 @@ describe( 'WcPayOverviewSurveyContextProvider', () => { ); - const surveyText = screen.getByText( 'Are those metrics helpful?' ); + const surveyText = screen.getByText( 'Are these metrics helpful?' ); expect( surveyText ).toBeInTheDocument(); const buttons = screen.getAllByRole( 'button' ); diff --git a/client/components/payment-activity/test/__snapshots__/index.test.tsx.snap b/client/components/payment-activity/test/__snapshots__/index.test.tsx.snap index 7e02d2dfc65..1b655775699 100644 --- a/client/components/payment-activity/test/__snapshots__/index.test.tsx.snap +++ b/client/components/payment-activity/test/__snapshots__/index.test.tsx.snap @@ -260,7 +260,7 @@ exports[`PaymentActivity component should render 1`] = `
- Are those metrics helpful? + Are these metrics helpful?
diff --git a/client/components/payment-activity/test/index.test.tsx b/client/components/payment-activity/test/index.test.tsx index 3d16ad70846..49e8726c02e 100644 --- a/client/components/payment-activity/test/index.test.tsx +++ b/client/components/payment-activity/test/index.test.tsx @@ -120,7 +120,7 @@ describe( 'PaymentActivity component', () => { const { container, getByText } = render( ); // Check survey is rendered. - getByText( 'Are those metrics helpful?' ); + getByText( 'Are these metrics helpful?' ); expect( container ).toMatchSnapshot(); } ); @@ -140,7 +140,7 @@ describe( 'PaymentActivity component', () => { const { queryByText } = render( ); expect( - queryByText( 'Are those metrics helpful?' ) + queryByText( 'Are these metrics helpful?' ) ).not.toBeInTheDocument(); } ); } );