Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-approve rebasing #29

Open
philipjohn opened this issue Nov 12, 2018 · 0 comments
Open

Auto-approve rebasing #29

philipjohn opened this issue Nov 12, 2018 · 0 comments
Labels
[Pri] Low

Comments

@philipjohn
Copy link

Sometimes, a PR is human reviewed, then the author needs to update the PR by rebasing against master. When that happens, the PR requires approval again.

However, we know that master is already approved so we should be able to auto-approve in this situation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Pri] Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philipjohn @gudmdharalds