Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot self dismiss request changes review on VIP approval #136

Open
davidsword opened this issue Dec 10, 2020 · 1 comment
Open

Bot self dismiss request changes review on VIP approval #136

davidsword opened this issue Dec 10, 2020 · 1 comment
Labels
[Pri] Normal [Type] Enhancement

Comments

@davidsword
Copy link

davidsword commented Dec 10, 2020 •
edited
Loading

After VIP approves a PR, VIP then needs to manually dismiss any bots 'request changes' review to unblock the PR.

It would be nice if a hook on review approvals could have the bot self dismiss its own stale reviews with something like 'superseded by VIP human review' after an approval by VIP staff.
@gudmdharalds
Copy link
Contributor

This is now on our roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Pri] Normal [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidsword @gudmdharalds