Proposal: automatically add strict types #7542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 12, 2023 11:20
This PR is an experiment that aims to check if it would be practical to automatically add strict types to all PHP files that are missing them. Initially, it will add them to _all_ PHP files, but con subsequen runs, it'll only affect new files. The strict types declaration has become a requirement on WordPress.com in order to commit new PHP files to the codebase, and solving this upstream (eg. on Create Block Theme) might not be the best, since prescribing strict types to its broad userbase could prove problematic.
vcanales
force-pushed
the
automatically-add-strict-types
branch
from
519f554
to
4642115
Compare
vcanales
force-pushed
the
automatically-add-strict-types
branch
from
93d74a1
to
93cc4b9
Compare
vcanales
force-pushed
the
automatically-add-strict-types
branch
from
93cc4b9
to
237f294
Compare
|
We've found some PHP files that don't have strict types. This commit adds them. Branch: add-strict-types-6150c21c0aa5b037c7d0cccf5ece2284bacdbd03 |
|
We've found some PHP files that don't have strict types. This commit adds them. Branch: add-strict-types-32ab06cbe1c614d546c550854c8f39837e089cf2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment that aims to check if it would be practical to automatically add strict types to all PHP files that are missing them. Initially, it will add them to all PHP files, but con subsequen runs, it'll only affect new files.
The strict types declaration has become a requirement on WordPress.com in order to commit new PHP files to the codebase, and solving this upstream (eg. on Create Block Theme) might not be the best, since prescribing strict types to its broad userbase could prove problematic.