Blockbase: Update the query pagination block markup #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
force-pushed
the
update/query-pagination-block-markup
branch
from
67943fd to
63c0e65
Compare
MaggieCabrera
force-pushed
the
update/query-pagination-block-markup
branch
from
7a5ae15 to
1f50552
Compare
|
This has made it to dotcom, I've rebased it and I'm bringing it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Since WordPress/gutenberg#35092 merged, the Query Pagination block doesn't have any markup. This removes the extra wrappers. We can't merge it until this version of GB ships on dotcom.
To test, run the latest GB and check that the query pagination block still looks ok.
Related issue(s):
WordPress/gutenberg#35092
Closes #4886