Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a theme.json file so that we can support border radius in Spearhead #3106

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Adds an experimental-theme.json file to Spearhead, so that it can support border radius controls in the Group bloc:

Screenshot 2021-01-26 at 14 11 12

Related issue(s):

Fixes #3093

@scruffian scruffian requested a review from a team January 26, 2021 14:11
@scruffian scruffian self-assigned this Jan 26, 2021
@MaggieCabrera
Copy link
Contributor

This LGTM and it's not triggering FSE or removing the customizer on wpcom.

@scruffian scruffian merged commit d5ba2f5 into trunk Jan 26, 2021
@scruffian scruffian deleted the fix/3093 branch January 26, 2021 14:35
@pbking
Copy link
Contributor

pbking commented Jan 27, 2021

YES! THAT's what I'm TALKING about. Incremental improvements by way of additional customization options for classic themes.

@mtias
Copy link
Member

mtias commented Jan 27, 2021

Should we also include the ones around padding? I've seen many themes that don't seem to have them (for Cover and Group)

@scruffian
Copy link
Member Author

It's on the list... #2449

@mtias
Copy link
Member

mtias commented Jan 27, 2021

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spearhead: Add support for group block's border radius setting
4 participants