Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact form block dropdown arrow wrapping under field in Assembler theme #8035

Closed
marissaexplores opened this issue Aug 23, 2024 · 7 comments · Fixed by Automattic/jetpack#40206
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Platform] Atomic [Platform] Simple [Pri] Low [Theme] Assembler [Type] Bug Something isn't working

Comments

@marissaexplores
Copy link

Quick summary

The dropdown arrow is under the dropdown field. It should be inline on the right side of the field.

contact-form-dropdown

Steps to reproduce

  1. Install and activate Assembler theme
  2. Add a contact form to any page.
  3. Add a dropdown field to the form
  4. View the arrow under the form.

A clear and concise description of what you expected to happen.

The arrow should be displayed on the right side of the field, inline with the text.

What actually happened

The arrow is displayed under the dropdown field.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Using this CSS as a workaround:

.contact-form .contact-form__select-wrapper::after {
  right: 15px;
  top: 50%;
}

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

I have tested the dropdown field on other themes like Twenty Twenty-Four, Annalee, and Outland. The issue does not occur on those themes. So it seems to only be an issue when using the Assembler theme.

@richtabor
Copy link
Contributor

I have tested the dropdown field on other themes like Twenty Twenty-Four, Annalee, and Outland. The issue does not occur on those themes. So it seems to only be an issue when using the Assembler theme.

Ideally there's a solution that resolves this as other themes does.

@MaggieCabrera MaggieCabrera self-assigned this Sep 3, 2024
@retnonindya retnonindya moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 5, 2024
@pauloeaquino
Copy link

8694098-zd

Recent build where the customer specifically requested for a dropdown field in their form. I used the CSS workaround for now.

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 8694098-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 10, 2024
@richtabor
Copy link
Contributor

@MaggieCabrera are you still planning on working on this?

@MaggieCabrera
Copy link
Contributor

@MaggieCabrera are you still planning on working on this?

Sorry, I think you assigned me to this and it got lost into a sea of notifications, I'm looking at it

@MaggieCabrera
Copy link
Contributor

I'm investigating this. So far I know that the culprit is this line:

padding: 0.8rem 1rem;

It looks like grunion (I thought that was deprecated, but some of the code lives in jetpack apparently) is doing some weird class swapping around, and if we modify the padding of the input element it preaks the arrow for the select. It's really hard to debug because the plugin is doing something with class swapping and rewriting the CSS, so it's not as simple as overriding the class. It was a matter of trial and error to actually verify that the selector apparently causing this problem is in fact input:not([type="submit"]):not([type="radio"]) when the element we are targeting is a select!!!

My suggestion is to remove the padding altogether or to target only the specific types that we want to modify and not try and target the general input element for this.

@MaggieCabrera
Copy link
Contributor

Automattic/jetpack#40206 should fix this, #8418 is a last resort in case that didn't get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Platform] Atomic [Platform] Simple [Pri] Low [Theme] Assembler [Type] Bug Something isn't working
Projects
5 participants