Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubic: spacing missing between gallery blocks #5814

Closed
mikachan opened this issue Apr 5, 2022 · 3 comments
Closed

Cubic: spacing missing between gallery blocks #5814

mikachan opened this issue Apr 5, 2022 · 3 comments
Assignees
Labels
[Theme] Cubic [Type] Bug Something isn't working

Comments

@mikachan
Copy link
Member

mikachan commented Apr 5, 2022

Steps to replicate

Since WordPress/gutenberg#38164 has merged, there will now be no default margin set between gallery blocks. This will affect themes that were relying on the margin on the gallery images to provide a gap between galleries, rather than actually setting a top margin to separate the blocks. As GB has switched from using margin to gap to separate the images in a gallery this removes this default separation.

Cubic is impacted by this:

Before After
image image

We could apply a CSS patch to fix this, for example:

figure.wp-block-gallery.has-nested-images {
    margin-top: 16px;
}

User report: p1649072900167279-slack-C029FM1EH

@mikachan mikachan added [Type] Bug Something isn't working [Theme] Cubic labels Apr 5, 2022
@Robertght Robertght added this to the Bug Herding 2022: Week 14 milestone Apr 5, 2022
@madhusudhand madhusudhand self-assigned this Apr 14, 2022
@madhusudhand
Copy link
Member

Parent theme boardwalk also impacted.

@pbking
Copy link
Contributor

pbking commented Apr 15, 2022

I see the potential fix can be found here: D78763-code

Looks like a situation isn't covered by that fix (yet) though. (.wp-block-gallery:not(.has-nested-images) and needs another look-see. Moving back to in-progress for some more tweaking.

@madhusudhand
Copy link
Member

Changes deployed and verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Cubic [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants