Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignments in post content not respected in block themes #5566

Closed
jffng opened this issue Feb 18, 2022 · 6 comments
Closed

Alignments in post content not respected in block themes #5566

jffng opened this issue Feb 18, 2022 · 6 comments
Labels
[Theme] Archeo Automatically generated label for Archeo. [Theme] Blockbase [Theme] Livro [Theme] Twenty Twenty-Two [Type] Bug Something isn't working

Comments

@jffng
Copy link
Contributor

jffng commented Feb 18, 2022 •
edited
Loading

Steps to replicate

  • Run Gutenberg trunk (after this PR has been merged), activate a block theme that contains this alignment CSS (Blockbase, TT2, Livro, Archeo...)
  • Visit to the alignments post
  • Verify the alignments are not respected

Result

Post content does not correctly align wide or full:

Screen Shot 2022-02-18 at 9 54 18 AM

Next steps

We should discuss the impact of the additional selectors — if they are needed, or if we need to rework the alignments CSS.
@jffng jffng added [Type] Bug Something isn't working [Theme] Blockbase [Theme] Livro [Theme] Twenty Twenty-Two [Theme] Archeo Automatically generated label for Archeo. labels Feb 18, 2022
@jffng jffng changed the title Alignments not respected in block themes Alignments in post content not respected in block themes Feb 18, 2022
@MaggieCabrera
Copy link
Contributor

WordPress/gutenberg#38947 should fix it

@jffng
Copy link
Contributor Author

jffng commented Feb 21, 2022

It did, thank you!

@jffng jffng closed this as completed Feb 21, 2022
@iamtakashi
Copy link
Contributor

I still see this issue in Site Editor. I've noticed it while I was playing with Livro that shows full content on the index. If this is better to be reported in WordPress/gutenberg#38947, Let me know.

Screenshot 2022-02-23 at 12 24 00

@jffng
Copy link
Contributor Author

jffng commented Feb 23, 2022

Thanks @iamtakashi, looks like there is still an issue with the query / post template. A solution is being explored in WordPress/gutenberg#39014 (comment).

We can re-open this for the time being.

@jffng jffng reopened this Feb 23, 2022
@jffng
Copy link
Contributor Author

jffng commented Mar 7, 2022 •
edited
Loading

We should verify this is fixed since WordPress/gutenberg#39164 was merged.

@jffng jffng closed this as completed Mar 7, 2022
@jffng jffng reopened this Mar 7, 2022
@MaggieCabrera
Copy link
Contributor

This looks ok to me, let's reopen if we find any alignments issues again.

Blockbase:

Screenshot 2022-03-07 at 11-25-17 Alignments – Skatepark

Livro:

Screenshot 2022-03-07 at 11-26-56 Skatepark – Tagline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Theme] Archeo Automatically generated label for Archeo. [Theme] Blockbase [Theme] Livro [Theme] Twenty Twenty-Two [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamtakashi @MaggieCabrera @jffng