Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrat: Hide query pagination divider if there's no pagination #4268

Closed
kjellr opened this issue Jul 22, 2021 · 4 comments · Fixed by #4805
Closed

Quadrat: Hide query pagination divider if there's no pagination #4268

kjellr opened this issue Jul 22, 2021 · 4 comments · Fixed by #4805
Assignees
Labels
[Theme] Quadrat [Type] Bug Something isn't working
Milestone

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 22, 2021

If there's no pagination available, we should not display the horizontal divider line for the Query Pagination:

Screen Shot 2021-07-22 at 7 52 50 AM

Screen Shot 2021-07-22 at 7 52 47 AM

@kjellr kjellr added [Type] Bug Something isn't working [Theme] Quadrat labels Jul 22, 2021
@kjellr kjellr added this to the Quadrat v1 milestone Jul 22, 2021
@jffng
Copy link
Contributor

jffng commented Jul 22, 2021

I wonder if this should ultimately be addressed in the block.

That is, if there is no pagination, an empty div should not be rendered. I will take a look at fixing it there.

@jffng jffng self-assigned this Jul 22, 2021
@kjellr
Copy link
Contributor Author

kjellr commented Jul 22, 2021

@jffng I'm not 100% sure, but I believe this happens with many other blocks too — for example, if there's no post title, an empty div for post title still shows up on the front end.

@jeffikus
Copy link
Contributor

This needs retesting.

@jeffikus jeffikus modified the milestones: Quadrat v1, Quadrat wpcom Sep 29, 2021
@scruffian
Copy link
Member

This is waiting for GB on dotcom to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Quadrat [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants