Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quadrat: translation #3653

Closed
4 tasks done
jffng opened this issue Apr 14, 2021 · 4 comments
Closed
4 tasks done

Quadrat: translation #3653

jffng opened this issue Apr 14, 2021 · 4 comments
Labels
[Theme] Quadrat
Milestone
Quadrat wpcom

Comments

@jffng
Copy link
Contributor

jffng commented Apr 14, 2021 •
edited by jeffikus
Loading

There are a few strings in the theme's block templates that we should figure out what to do with:

  • 404.html
  • footer.html
  • query.html (query navigation labels)
  • search.html
@jffng jffng added this to the Quadrat milestone Apr 14, 2021
@jffng
Copy link
Contributor Author

jffng commented May 26, 2021 •
edited
Loading

After discussing with the team, I don't think this within the realm of the theme to solve, especially not for v1.

Gutenberg needs to eventually expose a mechanism to translate strings inside block templates, strings + labels that are rendered by FSE blocks, etc. This is a known and tracked stream of work.

Edit
I'm not sure where i18n of FSE is on the roadmap or but here are a couple related issues:

WordPress/gutenberg#27402
WordPress/gutenberg#21932

@jffng jffng removed this from the Quadrat v1 milestone May 26, 2021
@scruffian
Copy link
Member

Removing this from TODO as it blocked.

This was referenced Jun 30, 2021
Closed
Closed
Closed
@scruffian
Copy link
Member

Another attempt: WordPress/gutenberg#33217

@scruffian scruffian mentioned this issue Jul 22, 2021
Merged
@jffng jffng mentioned this issue Jul 26, 2021
Merged
@iandunn iandunn mentioned this issue Aug 20, 2021
Open
@jeffikus
Copy link
Contributor

Tested this with @MaggieCabrera - marking as closed.

@jeffikus jeffikus added this to the Quadrat wpcom milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Theme] Quadrat
Projects
None yet
Milestone
Quadrat wpcom
Development

No branches or pull requests
3 participants
@scruffian @jeffikus @jffng