Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blank Canvas Blocks] Implement color variable system #3414

Closed
jffng opened this issue Mar 8, 2021 · 5 comments
Closed

[Blank Canvas Blocks] Implement color variable system #3414

jffng opened this issue Mar 8, 2021 · 5 comments
Assignees
Milestone

Comments

@jffng
Copy link
Contributor

jffng commented Mar 8, 2021

Add custom color variables via theme.json to be used throughout the blocks.

A theme will supply the 'descriptive color' values in the palette.

The ponyfill leverages "custom" css color variables and expects the following CSS color values to always be available and used when styling elements (all of them are in the form --wp--custom--color--SLUG)
"foreground, background, primary, secondary, tertiary"

@pbking
Copy link
Contributor

pbking commented Mar 8, 2021

This should be ready to review; accomplished when refactoring from ponyville to blank-canvas-blocks and can be reviewed on #3417

@scruffian
Copy link
Member

I thought the plan was to remove semantic colors from the color definitions until Gutenberg supports them - I still seem them in #3417

@pbking
Copy link
Contributor

pbking commented Mar 9, 2021

I understood the plan was to move them from the "root" configuration and back to "custom" because doing so made the Global Styles Editor work in a way that it wasn't intended (even if it was cool).

I don't think we should remove them completely. Even if they work differently "semantic color configuration" is something I expect Gutenberg to eventually do so is something relevant for the ponyfill.

@MaggieCabrera
Copy link
Contributor

From my understanding of WordPress/gutenberg#29568 I expect to have something relatively similar to what Jason implemented in the custom block. My comment on our call was about the bit that was initially on root, since that wasn't doing it the correct way with the current implementation. The idea is to have this custom implementation and then refactor when the editor is updated using semantic definitions. It's clearer to have it in custom since we know that will definitely be subject to change in the future.

@pbking
Copy link
Contributor

pbking commented Mar 9, 2021

Root color variables have been removed via #3433.

The branch matches the description now, closing this.

@pbking pbking closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants