Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet Blocks: Missing Front-end "Edit" Links #2274

Closed
ianstewart opened this issue Jul 20, 2020 · 4 comments
Closed

Seedlet Blocks: Missing Front-end "Edit" Links #2274

ianstewart opened this issue Jul 20, 2020 · 4 comments
Labels

Comments

@ianstewart
Copy link
Contributor

Here's a visual example of an Edit link in a traditional theme.

2020-07-20 11 31 43

This is the edit_post_link template tag in action. It's one of the template tags mentioned in a core issue for covering template tags for FSE.

Note about priority for Seedlet Blocks and WPcom FSE:

I don't (currently) think of this template tag as a blocker for testing FSE on WPcom in production. Though I do (currently) think we should have it in block-based themes.

@ianstewart ianstewart added the [Type] Bug Something isn't working label Jul 20, 2020
@apeatling
Copy link
Member

What would be the expectation for this block? Should it actually be a block in the editor? I started building it, but I'm trying to understand the reason for it appearing in the editor. Would a user want to edit the design or link text?

Another option would be to render it automatically on the front end at the end of the post-content block.

@apeatling
Copy link
Member

I guess users may also want to move the position of the edit link too?

@ianstewart
Copy link
Contributor Author

Great question. Perhaps it doesn't even need to be a block? Our activity bar (I think you built that?!) does have an edit link — although I personally find it hard to find.

I started building it

Note my note about priority. :D

@MaggieCabrera
Copy link
Contributor

There was a conversation about this link and the consensus was that it's not something we need or want to replicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants