Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash: Emojis Again! #397

Closed
jleandroperez opened this issue Nov 8, 2019 · 0 comments · Fixed by #398
Closed

Crash: Emojis Again! #397

jleandroperez opened this issue Nov 8, 2019 · 0 comments · Fixed by #398
Assignees
@jleandroperez
Labels
bug Something isn't working. [priority] high Fix/Feature needed as soon as possible.
Milestone
1.8

Comments

@jleandroperez
Copy link
Contributor

jleandroperez commented Nov 8, 2019 •
edited
Loading

Details:

  1. Add a new note
  2. Enter the following emojis: ☺️🖖🏿
  3. Insert the following emoji in between: 😃

As a result the app will crash. We'll end up with a malformed unicode sequence, which effectively breaks Apple's JSON Parser.

Extra!

Because of the malformed diff, AAPL's JSON Encoder breaks in the following spot:

Screen Shot 2019-11-06 at 8 43 01 PM
@jleandroperez jleandroperez added bug Something isn't working. [priority] high Fix/Feature needed as soon as possible. labels Nov 8, 2019
@jleandroperez jleandroperez added this to the 1.7.1 milestone Nov 8, 2019
@jleandroperez jleandroperez self-assigned this Nov 8, 2019
This was referenced Nov 8, 2019
Closed
Closed
Merged
@dmsnell dmsnell mentioned this issue Nov 13, 2019
Merged
@jleandroperez jleandroperez mentioned this issue Nov 14, 2019
Merged
1 task
@jleandroperez jleandroperez mentioned this issue Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleandroperez jleandroperez

Labels
bug Something isn't working. [priority] high Fix/Feature needed as soon as possible.
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Fixing Emojis Crash Automattic/simplenote-macos
1 participant
@jleandroperez