Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 'Invalid Usage' notice message taking extra space for Course Categories block #5517

Closed
Imran92 opened this issue Aug 23, 2022 · 2 comments · Fixed by #5546
Closed
Assignees
Labels
[Pri] Normal Can wait for the next release

Comments

@Imran92
Copy link
Contributor

Imran92 commented Aug 23, 2022

Goal

When a block that should be in a Course page or inside a Course List block is used outside of a course context and not inside them, we show an Invalid Usage notice. It shows as expected for all other blocks we've tested for but looks different for the Course Categories block.

We should fix it to look like other Invalid Usage notice

Screenshot

Image

@LavaGolem LavaGolem self-assigned this Aug 24, 2022
@LavaGolem
Copy link
Contributor

What I found so far is that Course Categories are wrapped inside the <div class="wp-block" data-align="left">
This adds some weird CSS to them.
Other examples are not wrapped inside that element.

I couldn't find the difference, but here are some similar issues I've found:
WordPress/gutenberg#33142
WordPress/gutenberg#23089

@github-actions
Copy link

Closed by #5546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants