Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to email/password in wear app #983

Closed
1 task done
mchowning opened this issue May 19, 2023 · 1 comment · Fixed by #1059
Closed
1 task done

Add validation to email/password in wear app #983

mchowning opened this issue May 19, 2023 · 1 comment · Fixed by #1059
Labels
[Area] Wear OS watch app [Type] Bug Not functioning as intended.

Comments

@mchowning
Copy link
Contributor

Description

Currently, the wear app does not do any validation of the email and password—it just sends off whatever the use enters to the server. If there is an error, it presents the server error or defaults to "Unable to login to you sync account, sorry. Try again later."

It would be better to validate that we have a valid email and a password that is long enough and present more relevant error messages like we do on the phone app.

image

h/t to @geekygecko for noting this

Step-by-step reproduction instructions

  1. Log into the watch app with an invalid email or password
  2. Observe the generic error message

Screenshots or screen recording

No response

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Watch emulator running pre-release 7.30 pre-release build

@mchowning mchowning added [Type] Bug Not functioning as intended. [Area] Wear OS watch app labels May 19, 2023
@mchowning mchowning changed the title Add validation to email/password validation to wear app Add validation to email/password in wear app Jun 1, 2023
@atharv028
Copy link
Contributor

The validations were added but the message was not displayed in the app, this PR fixes that.

Screenshots

Credentials Screens
Screenshot_20230606_190607 Screenshot_20230606_190618
Screenshot_20230606_190707 Screenshot_20230606_190714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Wear OS watch app [Type] Bug Not functioning as intended.
Development

Successfully merging a pull request may close this issue.

2 participants