hsl / hsla

[tj]

No description provided.

[RandomEtc]

I've got initial hsl(a) support plus some very basic tests working, added to context2d.js and canvas.test.js thus: RandomEtc@47032c1

Branch here: https://github.com/RandomEtc/node-canvas/tree/hsl

At least in the short term, are you happy with the color parsing continuing to happen in javascript? If so, and the above looks good, do I need to do a pull request or can you take it from here?

[tj]

awesome thanks man. yeah I am fine with it being js, it is cached so c would not be much faster. In fact I re-wrote it in c, and it is of couse way faster than js, but with caching involved there is little difference

[RandomEtc]

Great! I see you have benchmark and optimize on your issues list too so if this is really hurting someone (drawing random color wheels or something?) then it can always be revisited.

Thanks for an awesome library! Is there anywhere apart from these issue threads that we can discuss your plans? I'd love to help out more but I started hacking Image support in a day before you added it and that knocked the wind out of my sails a little bit :)

[tj]

for sure, I think that might be one of the only real use-cases for a faster parser. or the "ray.js" example I have.

id like to keep them in issues for now, even if it is a feature request

[tj]

merged, thanks!

[RandomEtc]

Hey, looks like this went away with the move to a C color parser? Is it something you're hoping to add back into rgba_from_string in https://github.com/LearnBoost/node-canvas/blob/master/src/color.cc or should I move it into my own js utils?

[tj]

yeah sorry about that, I would be happy to get it in there, just had most of this done already and wanted to get it in