Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): cleanup merge conflict markup #2335

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Left some merge conflict markup while merging trunk 🙇

This PR cleans it up!

How to test the changes in this Pull Request:

  1. Code review should be enough

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle requested a review from a team as a code owner July 3, 2024 17:48
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 3, 2024
@chickenn00dle chickenn00dle force-pushed the fix/merge-conflict-markup branch from 0517f35 to 6f84662 Compare July 3, 2024 17:50
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 4, 2024
@chickenn00dle chickenn00dle merged commit 080e0fc into epic/ras-acc Jul 8, 2024
4 checks passed
@chickenn00dle chickenn00dle deleted the fix/merge-conflict-markup branch July 8, 2024 14:39
matticbot pushed a commit that referenced this pull request Jul 8, 2024
# [1.91.0-epic-ras-acc.2](v1.91.0-epic-ras-acc.1...v1.91.0-epic-ras-acc.2) (2024-07-08)

### Bug Fixes

* **ras-acc:** clean up merge conflict marker ([#2335](#2335)) ([080e0fc](080e0fc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.91.0-epic-ras-acc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 17, 2024
# [1.92.0-epic-ras-acc.1](v1.91.0...v1.92.0-epic-ras-acc.1) (2024-07-17)

### Bug Fixes

* **ras-acc:** clean up merge conflict marker ([#2335](#2335)) ([080e0fc](080e0fc))

### Features

* add newspack-block-theme backwards compatibility ([#2315](#2315)) ([0e60c3a](0e60c3a))
* update clamp calculations based on viewport range of 782 - 1280 ([63307ae](63307ae))
* update Newspack UI variable font sizes for the theme ([212e2fd](212e2fd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.92.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 31, 2024
# [1.93.0-epic-ras-acc.1](v1.92.0...v1.93.0-epic-ras-acc.1) (2024-07-31)

### Bug Fixes

* **ras-acc:** clean up merge conflict marker ([#2335](#2335)) ([080e0fc](080e0fc))
* **ras-acc:** remove redundant checkout styles ([#2350](#2350)) ([1f48f20](1f48f20))

### Features

* update clamp calculations based on viewport range of 782 - 1280 ([63307ae](63307ae))
* update Newspack UI variable font sizes for the theme ([212e2fd](212e2fd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.93.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 14, 2024
# [2.1.0-epic-ras-acc.1](v2.0.0...v2.1.0-epic-ras-acc.1) (2024-08-14)

### Bug Fixes

* correct linting errors ([d3b74c7](d3b74c7))
* correct more linting errors ([593c246](593c246))
* **ras-acc:** clean up merge conflict marker ([#2335](#2335)) ([080e0fc](080e0fc))
* **ras-acc:** remove redundant checkout styles ([#2350](#2350)) ([1f48f20](1f48f20))

### Features

* update clamp calculations based on viewport range of 782 - 1280 ([63307ae](63307ae))
* update Newspack UI variable font sizes for the theme ([212e2fd](212e2fd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 12, 2024
# [2.3.0-epic-ras-acc.1](v2.2.0...v2.3.0-epic-ras-acc.1) (2024-11-12)

### Bug Fixes

* correct linting errors ([d3b74c7](d3b74c7))
* correct more linting errors ([593c246](593c246))
* **ras-acc:** clean up merge conflict marker ([#2335](#2335)) ([080e0fc](080e0fc))
* **ras-acc:** remove redundant checkout styles ([#2350](#2350)) ([1f48f20](1f48f20))

### Features

* update clamp calculations based on viewport range of 782 - 1280 ([63307ae](63307ae))
* update Newspack UI variable font sizes for the theme ([212e2fd](212e2fd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.3.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 26, 2024
# [2.4.0-epic-ras-acc.1](v2.3.0...v2.4.0-epic-ras-acc.1) (2024-11-26)

### Bug Fixes

* correct linting errors ([d3b74c7](d3b74c7))
* correct more linting errors ([593c246](593c246))
* **ras-acc:** clean up merge conflict marker ([#2335](#2335)) ([080e0fc](080e0fc))
* **ras-acc:** remove redundant checkout styles ([#2350](#2350)) ([1f48f20](1f48f20))

### Features

* update clamp calculations based on viewport range of 782 - 1280 ([63307ae](63307ae))
* update Newspack UI variable font sizes for the theme ([212e2fd](212e2fd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @epic/ras-acc [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants