fix(woocommerce-emails): use the default email if there are no donation products #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
the
[Status] Needs Review
leogermani
reviewed
Nov 13, 2024
| @@ -266,6 +266,19 @@ public static function force_disable_order_attribution( $should_allow ) { | |||
| * @return bool | |||
| */ | |||
| public static function send_customizable_receipt_email( $enable, $order, $class ) { | |||
| // If there are no donation products in the order, do not override the default WC receipt email. | |||
| $has_donation_product = false; | |||
There was a problem hiding this comment.
In other places we check this using
$product_id = \Newspack\Donations::get_order_donation_product_id( $order_id );
which is basically the same thing you do here. Isn't it simples if we just use that?
There was a problem hiding this comment.
Huh, thanks! Changed in b3e62f0
leogermani
approved these changes
Nov 18, 2024
github-actions
bot
added
[Status] Approved
|
Hey @adekbadek, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Nov 29, 2024
# [5.9.0-alpha.1](v5.8.1...v5.9.0-alpha.1) (2024-11-29) ### Bug Fixes * **ras-acc:** make helper text size more specific ([#3584](#3584)) ([5bcc688](5bcc688)) * undefined var ([#3585](#3585)) ([00d8bc7](00d8bc7)) * **woocommerce-emails:** use the default email payload if there are no donation products ([#3545](#3545)) ([60c21f3](60c21f3)) ### Features * mark perfmatters as a required plugin ([#3578](#3578)) ([f20291c](f20291c)) * **ras-acc:** add reader account creation and login improvements ([#3582](#3582)) ([b66de08](b66de08)) * **reader-data:** add a CLI command to align reader membership data ([#3548](#3548)) ([8e49bf0](8e49bf0)) * **subscriptions:** add setting to reattempt payment after final retry ([#3560](#3560)) ([553c3ac](553c3ac)) * **woocommerce:** remove internal metadata from REST API response ([6b659a6](6b659a6))
|
🎉 This PR is included in version 5.9.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 9, 2024
# [5.9.0](v5.8.2...v5.9.0) (2024-12-09) ### Bug Fixes * **emails:** account for false order value ([#3590](#3590)) ([a2e4042](a2e4042)) * **ras-acc:** correct My Account custom font sizing clash ([#3588](#3588)) ([080f1ce](080f1ce)) * **ras-acc:** make helper text size more specific ([#3584](#3584)) ([5bcc688](5bcc688)) * **ras-acc:** re-add recaptcha to the WooCommerce checkout ([#3605](#3605)) ([07f46b3](07f46b3)) * undefined var ([#3585](#3585)) ([00d8bc7](00d8bc7)) * **woocommerce-emails:** use the default email payload if there are no donation products ([#3545](#3545)) ([60c21f3](60c21f3)) ### Features * mark perfmatters as a required plugin ([#3578](#3578)) ([f20291c](f20291c)) * **ras-acc:** add reader account creation and login improvements ([#3582](#3582)) ([b66de08](b66de08)) * **reader-data:** add a CLI command to align reader membership data ([#3548](#3548)) ([8e49bf0](8e49bf0)) * **subscriptions:** add setting to reattempt payment after final retry ([#3560](#3560)) ([553c3ac](553c3ac)) * **woocommerce:** remove internal metadata from REST API response ([6b659a6](6b659a6))
|
🎉 This PR is included in version 5.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes the custom receipt emails, so that they are not sent for order which do not contain donation products.
How to test the changes in this Pull Request:
Other information: