Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid deepMapKeys NPM package #2680

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: avoid deepMapKeys NPM package #2680

merged 2 commits into from
Oct 2, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 2, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

The deep-map-keys NPM package is throwing a lodash dependency error. Since this package hasn't received an update in 5+ years, let's not rely on it anymore.

How to test the changes in this Pull Request:

  1. On release, visit Newspack > SEO and observe a JS error:

image__16_

  1. Check out this branch, refresh, confirm no error.
  2. Update values for each setting, save, refresh, confirm all values are persisted.

Bonus: Better error messaging in Connections wizard

  1. Go to Newspack > Connections
  2. Force an error in any of the third-party connection components (Google, Mailchimp, Fivetran, reCAPTCHA) by adding a setError( 'TEST' ); call in the component render function
  3. Confirm that the error message is prefixed with the name of the service:
Screenshot 2023-10-02 at 4 00 35 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Oct 2, 2023
@dkoo dkoo requested a review from a team as a code owner October 2, 2023 21:51
@dkoo dkoo self-assigned this Oct 2, 2023
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 2, 2023
@dkoo dkoo merged commit 60b9828 into release Oct 2, 2023
1 check passed
@dkoo dkoo deleted the hotfix/no-deep-map-keys branch October 2, 2023 22:13
matticbot pushed a commit that referenced this pull request Oct 2, 2023
@semantic-release-bot
chore(release): 2.7.4 [skip ci]
94f0506 
## [2.7.4](v2.7.3...v2.7.4) (2023-10-02)

### Bug Fixes

* avoid deepMapKeys NPM package ([#2680](#2680)) ([60b9828](60b9828))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 2, 2023
@semantic-release-bot
chore(release): 2.8.0-alpha.6 [skip ci]
21c719f 
# [2.8.0-alpha.6](v2.8.0-alpha.5...v2.8.0-alpha.6) (2023-10-02)

### Bug Fixes

* avoid deepMapKeys NPM package ([#2680](#2680)) ([60b9828](60b9828))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@miguelpeixe miguelpeixe mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees

@dkoo dkoo

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @miguelpeixe