Couple bug fixes for ESP sync CLI command #3615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Note: This is a hotfix PR.
This PR fixes a couple bugs in the ESP sync CLI command.
[--subscription-ids=<id1,id2...>]
, so those parameters weren't getting recognized.$customer
object didn't exist.How to test the changes in this Pull Request:
wp newspack esp sync --user-ids=1
. Observe the following output:ESP_Sync::sync_contact
so an error is always thrown:wp newspack esp sync
. Observe output like the following:--user-ids
flag works and that when an error is thrown you now get something likeError syncing contact info for user ID 3. Customer with ID 1 does not exist
instead of a fatal error.Other information: