Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): newspack ui heading font weights #3296

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1207878733150043/f

Seems all bolded text, headings included, should have a font weight of 600 per the task above. This PR forces the 600 font weight on headings.

Screenshot 2024-07-31 at 16 35 19

How to test the changes in this Pull Request:

  1. Open the checkout modal and confirm each heading has a font weight of 600 throughout the modal
  2. Repeat the above step for the auth modal

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle added [Status] Needs Review The issue or pull request needs to be reviewed ras-acc testing labels Jul 31, 2024
@chickenn00dle chickenn00dle requested a review from a team as a code owner July 31, 2024 20:36
@chickenn00dle chickenn00dle changed the base branch from trunk to epic/ras-acc August 2, 2024 14:32
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I did the functional testing for this first, so seeing the actual code change under the hood made me laugh 😄

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 2, 2024
@chickenn00dle chickenn00dle merged commit 33cb637 into epic/ras-acc Aug 2, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/checkout-form-heading-weights branch August 2, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ras-acc testing [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants