Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): correctly update myaccount link after signing in #3271

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Jul 24, 2024

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1207836619707355/f

This PR ensures we are always updating the RAS-ACC my account button URL after successfully signing in or creating an account.

Screenshot 2024-07-24 at 12 58 48

How to test the changes in this Pull Request:

  1. As a new reader, create an account via the sign in button auth modal:
    Screenshot 2024-07-24 at 12 59 39
  2. After signup is complete, select the my account button (pictured above) and confirm you are directed to my account.
  3. Log out and go back to the home page
  4. Log in to the same account via the sign in button
  5. After logging in, select the my account button and confirm you are directed to my account.
  6. Log out again and visit any page or post with a donate or checkout block as a reader
  7. Go through the auth/checkout flow via the donate/checkout block
  8. Once checkout is complete, select the my account button and confirm you are directed to my account.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle requested a review from a team as a code owner July 24, 2024 17:05
@chickenn00dle chickenn00dle added [Status] Needs Review The issue or pull request needs to be reviewed and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 24, 2024
@chickenn00dle chickenn00dle force-pushed the fix/my-account-link-post-signin branch from 63b0931 to 7c9a770 Compare July 24, 2024 18:11
@chickenn00dle chickenn00dle force-pushed the fix/my-account-link-post-signin branch from 7c9a770 to d167e83 Compare July 24, 2024 18:11
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 24, 2024
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 24, 2024
@chickenn00dle chickenn00dle merged commit db105dc into epic/ras-acc Jul 24, 2024
9 checks passed
@chickenn00dle chickenn00dle deleted the fix/my-account-link-post-signin branch July 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ras-acc testing [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants