Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reader-registration): custom checkbox state for lists #2682

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Oct 4, 2023

All Submissions:

Changes proposed in this Pull Request:

1200550061930446-as-1205543124448992

Similar to Automattic/newspack-newsletters#1313, support toggling and storing the checkbox state for defining the initial form state:

image

How to test the changes in this Pull Request:

  1. Draft a new page and add a Newsletter Subscription Form block
  2. Enable multiple lists and toggle their checkbox state in the editor
  3. Save, refresh, and confirm the selected state is preserved
  4. Visit the page and confirm the selected state is also reflected on the page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Oct 4, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner October 4, 2023 13:54
@miguelpeixe miguelpeixe self-assigned this Oct 4, 2023
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 11, 2023
@dkoo dkoo merged commit b8ce865 into master Oct 12, 2023
2 checks passed
@dkoo dkoo deleted the feat/reader-registration-checkbox-state branch October 12, 2023 18:54
matticbot pushed a commit that referenced this pull request Oct 16, 2023
# [2.9.0-alpha.1](v2.8.3...v2.9.0-alpha.1) (2023-10-16)

### Features

* add Perfmatters to managed plugins ([#2684](#2684)) ([eb657d8](eb657d8))
* **design-wizard:** allow bulk update of featured image, post template ([#2670](#2670)) ([37a4656](37a4656))
* newspack_managed_plugins filter ([#2605](#2605)) ([81ba5f2](81ba5f2))
* **reader-registration:** custom checkbox state for lists ([#2682](#2682)) ([b8ce865](b8ce865))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 17, 2023
# [2.10.0-alpha.1](v2.9.0...v2.10.0-alpha.1) (2023-10-17)

### Features

* add Perfmatters to managed plugins ([#2684](#2684)) ([eb657d8](eb657d8))
* **design-wizard:** allow bulk update of featured image, post template ([#2670](#2670)) ([37a4656](37a4656))
* newspack_managed_plugins filter ([#2605](#2605)) ([81ba5f2](81ba5f2))
* **reader-registration:** custom checkbox state for lists ([#2682](#2682)) ([b8ce865](b8ce865))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.10.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 31, 2023
# [2.10.0](v2.9.1...v2.10.0) (2023-10-31)

### Features

* add Perfmatters to managed plugins ([#2684](#2684)) ([eb657d8](eb657d8))
* **data-events:** activecampaign connector ([#2663](#2663)) ([377a51f](377a51f))
* **design-wizard:** allow bulk update of featured image, post template ([#2670](#2670)) ([37a4656](37a4656))
* newspack_managed_plugins filter ([#2605](#2605)) ([81ba5f2](81ba5f2))
* **ras:** custom newsletter list selection on registration ([#2706](#2706)) ([57b2871](57b2871))
* **ras:** overlay management for content gate refresh ([#2708](#2708)) ([6767740](6767740))
* **reader-registration:** custom checkbox state for lists ([#2682](#2682)) ([b8ce865](b8ce865))
* remove order-received text ([#2707](#2707)) ([a386524](a386524))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants