Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/iframed previews #685

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Fix/iframed previews #685

merged 4 commits into from
Jan 14, 2022

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

A few fixes for bugs that were introduced by WordPress 5.9.

Before After
image image

Note that these changes will not work on Firefox due to WordPress/gutenberg#37961

How to test the changes in this Pull Request:

The bugs listed above should be fixed (in Chrome and Safari) and the layout and Post Inserter previews should continue to work as expected in 5.8.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! It also does partially fix the display in FF for me, at least by removing the border from the nested iframe.

@dkoo
Copy link
Contributor

dkoo commented Jan 14, 2022

Also tested in WP 5.8 and didn't see any regressions there.

@miguelpeixe
Copy link
Member Author

miguelpeixe commented Jan 14, 2022

Thank you for reviewing, @dkoo!

@miguelpeixe miguelpeixe merged commit 2abb6e2 into master Jan 14, 2022
@miguelpeixe miguelpeixe deleted the fix/iframed-previews branch January 14, 2022 20:31
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.39.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glitchy scrollbar on layout preview Post Inserter displaying controls on layout preview
3 participants