-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: execute tracking in an earlier hook #1314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dkoo
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described!
github-actions
bot
added
[Status] Approved
Ready to merge
and removed
[Status] Needs Review
labels
Oct 5, 2023
matticbot
pushed a commit
that referenced
this pull request
Oct 5, 2023
## [2.1.4](v2.1.3...v2.1.4) (2023-10-05) ### Bug Fixes * execute tracking in an earlier hook ([#1314](#1314)) ([e48aeab](e48aeab))
🎉 This PR is included in version 2.1.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Oct 5, 2023
# [2.2.0-alpha.2](v2.2.0-alpha.1...v2.2.0-alpha.2) (2023-10-05) ### Bug Fixes * execute tracking in an earlier hook ([#1314](#1314)) ([e48aeab](e48aeab))
🎉 This PR is included in version 2.2.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The existing approach for processing the pixel and click tracking processes the requests in the
template_redirect
hook, which can potentially be quite heavy being a hook called farther down the hook tree.Removing the custom rewrite rule allows the hook to be executed early in
init
, which is executed much earlier, reducing the load of such requests.The rewrite rule and the hook to
template_redirect
will continue to exist for backward compatibility, but every new newsletter sent will use a query parameter, which will be executed in the new hook.How to test the changes in this Pull Request:
release
branch, send a newsletter with linksOther information: