Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when products are enabled but WC Subscriptions isn't active #121

Closed
dkoo opened this issue Sep 15, 2021 · 2 comments · Fixed by #122
Closed

Fatal error when products are enabled but WC Subscriptions isn't active #121

dkoo opened this issue Sep 15, 2021 · 2 comments · Fixed by #122

Comments

@dkoo
Copy link
Contributor

dkoo commented Sep 15, 2021

When the NEWSPACK_LISTINGS_SELF_SERVE_ENABLED environment constant is set to true, Newspack Listings self-serve products are available. However, the products class assumes both WooCommerce and the WooCommerce Subscriptions extension are active; it's possible for the base WC plugin to be active but the Subscriptions extension to not be. In the latter case, Newspack Listings will throw an unhandled fatal error, taking down the whole site.

@dkoo dkoo added bug Something isn't working Priority: High labels Sep 15, 2021
@dkoo dkoo self-assigned this Sep 15, 2021
@dkoo dkoo added this to the Self-Serve Listings milestone Sep 15, 2021
@dkoo dkoo closed this as completed in #122 Sep 16, 2021
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants