Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Posts Block - Featured Images Oversized and Overlap in the Editor #1826

Open
donalirl opened this issue Aug 3, 2024 · 16 comments · Fixed by #1920
Open

Blog Posts Block - Featured Images Oversized and Overlap in the Editor #1826

donalirl opened this issue Aug 3, 2024 · 16 comments · Fixed by #1920
Labels
Block: Blog Posts Block Theme Requirement bug Something isn't working Groundskeeping Issues handled through Dotcom Groundskeeping rotations Involves Happiness This issue was created by a Happiness Engineer or contributed to by a Happiness Engineer [Pri] Normal released on @alpha released Triaged [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@donalirl
Copy link

donalirl commented Aug 3, 2024

Describe the bug
Images in the Blog Posts block (grid view) appear distorted in the editor, making it difficult to edit the site.

To Reproduce
Steps to reproduce the behavior:

  1. Activate a block theme
  2. Visit the site editor and edit the homepage template
  3. Add a Blog Posts block
  4. In the toolbar, choose Grid View
  5. Ensure three posts are loaded and that each post has a featured image

Screenshots
Images are suddenly extremely large and pushed up against each other:
Screenshot 2024-08-03 at 10 31 54 AM

Expected behavior
I expected the editor view to show the images with correct spacing, like we see on the live site:
Screenshot 2024-08-03 at 10 34 52 AM

@donalirl donalirl added bug Something isn't working Involves Happiness This issue was created by a Happiness Engineer or contributed to by a Happiness Engineer User Report This issue was created following a WordPress customer report [Type] Bug Block: Blog Posts Needs triage labels Aug 3, 2024
@philnick206
Copy link

Another report: 8582019-zd-a8c

@mxhassani
Copy link

mxhassani commented Aug 26, 2024

Another one: 8622597-zen
Theme: Masu
Workaround: use query loop block

@masperber masperber changed the title Blog Posts block appears distorted in the editor Blog Posts Block - Featured Images Oversized and Overlap in the Editor Aug 29, 2024
@masperber
Copy link

Another report here: 8663356-zd-a8c

@m1r0
Copy link
Member

m1r0 commented Sep 10, 2024

I was able to reproduce it.

cc @Automattic/newspack-product to increase visibility.

@laurelfulford
Copy link
Contributor

Thanks for the reports, all!

It look like this is related to this optimization change that loads some of the editor styles as needed -- these styles include a max-width for the images, and they're being loaded into the regular post editor but not the site editor: #1548

We'll be looking into a fix!

@m1r0 m1r0 added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Sep 11, 2024
@leogermani
Copy link
Contributor

is this related? #1878

@dev-sabbir
Copy link

Another one here: 8770806-zd-a8c

@Robertght
Copy link

8914025-zen

It seems the issue is more present on the Atomic sites and modern themes as classic ones appear to work correctly.

I tested with Gourmetto and Dara.

@leogermani
Copy link
Contributor

Being fixed on #1920. Once it's released I'll add a comment here

@laurelfulford
Copy link
Contributor

Reopening this since the issue isn't merged to WP.com yet 😬 The closing was my fault, I added the comment to the PR without thinking.

@laurelfulford laurelfulford reopened this Oct 22, 2024
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 4.3.5-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Robertght
Copy link

@laurelfulford I can see this was released, but it's not clear if it's merged into dotcom yet. Can we please have this merged as well?

@adekbadek
Copy link
Member

It's released on the alpha channel. When it will be released on the main release channel (there will be another bot ping here), it'll be possible to merge it to dotcom.

@ezebecke
Copy link

ezebecke commented Nov 8, 2024

Reported also on 9013627-zd

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 4.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mxhassani
Copy link

9028589-zen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block: Blog Posts Block Theme Requirement bug Something isn't working Groundskeeping Issues handled through Dotcom Groundskeeping rotations Involves Happiness This issue was created by a Happiness Engineer or contributed to by a Happiness Engineer [Pri] Normal released on @alpha released Triaged [Type] Bug User Report This issue was created following a WordPress customer report
Projects
Development

Successfully merging a pull request may close this issue.