Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Styles: Reduce specificity of body selector #37043

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Apr 24, 2024

Fixes Automattic/wp-calypso#89631
Related to WordPress/gutenberg#60106, p1713865028094699-slack-CDLH4C1UZ

Proposed changes:

Referring to WordPress/gutenberg#60106, it would be better to reduce the specificity of the body selector on Jetpack to avoid the styles of the font family being overridden. I'm unsure of the purpose of the body styles but I guess we can consider removing them later

Here is the result of Bedrock theme:

Screenshot 2024-04-24 at 12 50 26 PM

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Follow Base Styles: Reduce specificity of body selector #37043 (comment) to apply the changes on your site
    • You have to apply this branch to Jetpack & Jetpack VideoPress on atomic sites
  • Remember to disable the cache before getting started
  • Go through pages under the Jetpack
  • Make sure the styles look good
  • Activate any of these themes: Kingsley, Arbutus, and Geologist (or probably any theme).
  • Create a new post
  • Add a paragraph with sample text.
  • Make sure the fonts are rendered correctly
  • Go to the Site Editor
  • Add jetpack blocks
  • Make sure the styles of jetpack blocks look good

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the feat/reduce-specificity-of-body-selector branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack feat/reduce-specificity-of-body-selector
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Apr 24, 2024
@arthur791004 arthur791004 self-assigned this Apr 24, 2024
@arthur791004 arthur791004 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 24, 2024
@arthur791004 arthur791004 requested a review from a team April 24, 2024 05:09
@taipeicoder
Copy link
Contributor

@arthur791004 I added a post using the Bedrock theme and the fonts render fine. The post also has Jetpack blocks. See https://griffithchen01.blog/2024/04/24/site-title/
Am I missing anything?

@arthur791004
Copy link
Contributor Author

I added a post using the Bedrock theme and the fonts render fine. The post also has Jetpack blocks. See https://griffithchen01.blog/2024/04/24/site-title/
Am I missing anything?

Do they render correctly in the post editor?

@taipeicoder
Copy link
Contributor

I added a post using the Bedrock theme and the fonts render fine. The post also has Jetpack blocks. See https://griffithchen01.blog/2024/04/24/site-title/
Am I missing anything?

Do they render correctly in the post editor?

Thanks, I was testing the Front End 😄

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended!

Before After
Screenshot 2024-04-24 at 4 27 36 PM Screenshot 2024-04-24 at 4 32 03 PM

@arthur791004 arthur791004 merged commit 61f96da into trunk Apr 25, 2024
75 of 78 checks passed
@arthur791004 arthur791004 deleted the feat/reduce-specificity-of-body-selector branch April 25, 2024 01:42
@github-actions github-actions bot removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy in Font Family between Editor and Front End
2 participants