Admin menu: Avoid usage of pseudorandom numbers in tests

[mmtr]

Changes proposed in this Pull Request:

WordPress 6.0 will change how menus are positioned when there is a collision between items that are supposed to be in the same position: https://core.trac.wordpress.org/ticket/40927

In such cases, WordPress generates a pseudorandom number to be used as the position key in order to guarantee there are no duplicated keys. However, the logic for generating that number has changed in WordPress 6.0.

We had a couple of tests that relied on such number, so to avoid failures in these tests in WordPress 6.0 this PR adapts their implementation to don't rely in it.

Originally reported by @david-binda in D79094-code.

Jetpack product discussion

• See WordPress 6.0 compatibility #24082

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Make sure tests pass.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello mmtr! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D79957-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: June 7, 2022.
• Scheduled code freeze: May 30, 2022.

[jeherve]

I looked at that issue in #24083, and took a different approach there. I suppose your approach is simpler though :)

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D79957-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[kraftbj]

r244847-wpcom

[anomiex]

In such cases, WordPress generates a pseudorandom number to be used as the position key in order to guarantee there are no duplicated keys.

It's not at all pseudorandom. It hashes the menu title and slug.

[mmtr]

It's not at all pseudorandom. It hashes the menu title and slug.

Right, I took that from what was said in https://core.trac.wordpress.org/ticket/40927#comment:40, but it's not pseudoramdom at all, just a hash.

Anyway, I don't think we should have logic/tests that expects a certain menu position hash given that WordPress doesn't expose it in any way and should be considered as unreliable/indeterminate.

[david-binda]

Thank you all for working on this! 🙇

[jeherve]

Cherry-picked to jetpack/branch-10.9 in a283d48