Load the i18n-map in plugins #22143
Merged
Load the i18n-map in plugins #22143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Jetpack, this will keep the packages' i18n working once we update the packages to use aliasable domains instead of "jetpack". For Backup and Boost, this will make the packages' i18n _start_ working once we do that update (and once a version with `jetpack_vendor/` is pushed to wporg svn so the translations exist). When we add use of jetpack-composer-plugin to other plugins (e.g. Search), we'll need to remember to do something similar to each of them too.
anomiex
added
[Status] Needs Review
github-actions
bot
added
[Plugin] Backup
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
Backup plugin:
Boost plugin:
|
sdixon194
approved these changes
Dec 20, 2021
github-actions
bot
removed
the
[Status] Needs Review
anomiex
added a commit
that referenced
this pull request
Dec 22, 2021
To finally fix #21690, we need each package to have its own textdomain and to declare that domain in its `composer.json`. The work done in previous PRs will take it from there: composer-plugin will include the packages' domains in the generated `i18n-map.php` (#22096), which the plugin will pass to the Assets package (#22143), which will map those package textdomains to the plugin's (#22083). This also adds checks to the monorepo linting script to help people get the setup right: * Packages may not use a textdomain that matches a plugin slug. * If the package's phpcs config or eslint config sets a textdomain (which it will have to if it uses i18n after #22117 and #22131), require that same textdomain is set in composer.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
For Jetpack, this will keep the packages' i18n working once we update
the packages to use aliasable domains instead of "jetpack".
For Backup and Boost, this will make the packages' i18n start working
once we do that update (and once a version with
jetpack_vendor/ispushed to wporg svn so the translations exist).
When we add use of jetpack-composer-plugin to other plugins (e.g.
Search), we'll need to remember to do something similar to each of them
too.
Jetpack product discussion
For #21690
Does this pull request change what data or activity we track or use?
No
Testing instructions: