-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search package: move search dashboard to package (2/2) #21888
Merged
jeherve
merged 187 commits into
master
from
update/search-move-search-dashboard-to-package-2
Jan 11, 2022
Merged
Search package: move search dashboard to package (2/2) #21888
jeherve
merged 187 commits into
master
from
update/search-move-search-dashboard-to-package-2
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e rest controller
kangzj
added
DO NOT MERGE
don't merge it!
and removed
[Status] Needs Team Review
labels
Dec 16, 2021
github-actions
bot
added
the
[Status] Needs Author Reply
We would need you to make some changes or provide some more details about your PR. Thank you!
label
Dec 16, 2021
kangzj
added
[Status] Needs Review
To request a review from fellow Jetpack developers. Label will be renamed soon.
and removed
[Status] Needs Author Reply
We would need you to make some changes or provide some more details about your PR. Thank you!
labels
Dec 16, 2021
jeherve
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me, after a rebase and a few i18n adjustments. Nice work! 🚢
Great news! One last step: head over to your WordPress.com diff, D70859-code, and commit it. Thank you! |
github-actions
bot
removed
the
[Status] Needs Review
To request a review from fellow Jetpack developers. Label will be renamed soon.
label
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Admin Page
React-powered dashboard under the Jetpack menu
[Block] VideoPress
E2E Tests
[Feature] Search
For all things related to Search
[JS Package] API
[JS Package] Connection
[JS Package] IDC
[JS Package] Licensing
[Package] Connection UI
This package no longer exists in the monorepo.
[Package] Search
Contains core Search functionality for Jetpack and Search plugins
[Plugin] Backup
A plugin that allows users to save every change and get back online quickly with one-click restores.
[Plugin] Jetpack
Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
RNA
Touches WP.com Files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is the final PR to move search dashboard to the search package. The PR takes the chance to refactor some parts, including, renaming, changing to use redux hooks and some tiny bits. This increases the difficulty for reviewing as some files couldn't be detected as renamed but deleted/added - I'm sorry about that. I've tried to split off some PRs to be reviewed separatedly, and this is the minimal set I can do for the rest. If you have any suggestions, I'd be happy to hear them.
Other than the migration, the PR also added sucess / failed notice, and improved availability by allowing toggling by clicking labels.
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions:
/wp-admin/admin.php?page=jetpack-search
cd projects/packages/search && pnpm test
cd projects/packages/search && composer phpunit