Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search package: move search dashboard to package (2/2) #21888

Merged
merged 187 commits into from
Jan 11, 2022

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Nov 28, 2021

Changes proposed in this Pull Request:

This is the final PR to move search dashboard to the search package. The PR takes the chance to refactor some parts, including, renaming, changing to use redux hooks and some tiny bits. This increases the difficulty for reviewing as some files couldn't be detected as renamed but deleted/added - I'm sorry about that. I've tried to split off some PRs to be reviewed separatedly, and this is the minimal set I can do for the rest. If you have any suggestions, I'd be happy to hear them.

Other than the migration, the PR also added sucess / failed notice, and improved availability by allowing toggling by clicking labels.

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Open a site with Search subscription
  • Navigate to /wp-admin/admin.php?page=jetpack-search
  • Ensure the page looks okay under different resolutions
  • Ensure you could toggle the search module and instant search experience
  • Ensure there's updating/success/failed notice accordingly
  • Ensure JS tests pass cd projects/packages/search && pnpm test
  • Ensure PHP tests pass cd projects/packages/search && composer phpunit

@kangzj kangzj added DO NOT MERGE don't merge it! and removed [Status] Needs Team Review labels Dec 16, 2021
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 16, 2021
@kangzj kangzj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 16, 2021
@jsnmoon jsnmoon removed the DO NOT MERGE don't merge it! label Dec 23, 2021
@kangzj kangzj requested a review from a team January 5, 2022 22:16
@jeherve jeherve added this to the jetpack/10.6 milestone Jan 11, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me, after a rebase and a few i18n adjustments. Nice work! 🚢

@jeherve jeherve merged commit dfb2a7a into master Jan 11, 2022
@jeherve jeherve deleted the update/search-move-search-dashboard-to-package-2 branch January 11, 2022 15:12
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D70859-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Block] VideoPress E2E Tests [Feature] Search For all things related to Search [JS Package] API [JS Package] Connection [JS Package] IDC [JS Package] Licensing [Package] Connection UI This package no longer exists in the monorepo. [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants