-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMP compatibility for OpenTable block #17085
Add AMP compatibility for OpenTable block #17085
Conversation
Scheduled Jetpack release: October 6, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17085 Thank you for the great PR description! When this PR is ready for review, please apply the |
26016d2
to
aadba1d
Compare
@jeherve No longer |
Internal reference: D50129-code |
aadba1d
to
f0b54e1
Compare
See #14395
This fixes AMP compatibility for the OpenTable block by rendering an
amp-iframe
as opposed to the embedscript
on AMP pages. Note that the block edit function similarly constructs and iframe for preview purposes, so manually constructing the iframe is not unprecedented.👉 Note this is currently blocked by an AMP bug which has been fixed upstream but is not yet in production. See ampproject/amphtml#29398. In order to test this PR, you need to first opt-in to to theThe fix is now live.beta-channel
on the AMP Experiments page. The fix should be rolled out to AMP's production channel by September 22nd.Given this HTML content:
Changes proposed in this Pull Request:
amp-iframe
on AMP pages as opposed to OpenTable embed script.Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Proposed changelog entry for your changes: