Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Compatibility: Map block #19482

Closed
andrewserong opened this issue Apr 9, 2021 · 1 comment
Closed

Site Editor Compatibility: Map block #19482

andrewserong opened this issue Apr 9, 2021 · 1 comment
Assignees
Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Type] Bug When a feature is broken and / or not performing as intended

Comments

@andrewserong
Copy link
Member

In the new site editor in Gutenberg (/wp-admin/admin.php?page=gutenberg-edit-site), there are some issues with the Map block in the editor. The Map block itself appears to be able to be initialised within the site editor canvas, likely as a result of the editor canvas being rendered within an iframe. It looks like Mapbox expects to be given a string to match against a DOM node, or be given a DOM node.

Is there a way for us to get the Mapbox initialisation to play nicely with an iframe?

Steps to reproduce the issue

  1. With the Gutenberg plugin active (>=10.4.0-rc1), activate a block-ready theme (like tt1-blocks)
  2. In the site editor, insert a Map block into the Footer template part
  3. Observe that the map block throws an error as in the screenshot below
  4. Save the template part
  5. Observe that the map does render on the front end of the site

What I expected

The map to render and be usable within the editor

What happened instead

The map isn't rendered, and throws an error
image

@andrewserong andrewserong added [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Map [Type] Bug When a feature is broken and / or not performing as intended [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg labels Apr 9, 2021
@glendaviesnz glendaviesnz self-assigned this Apr 14, 2021
@glendaviesnz
Copy link
Contributor

Fixed by #19552, but follow up issue added to refactor to new api when stable - #19896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants