Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTable Block: Notice and Warning when empty block is published #15129

Closed
brbrr opened this issue Mar 26, 2020 · 0 comments · Fixed by #15133
Closed

OpenTable Block: Notice and Warning when empty block is published #15129

brbrr opened this issue Mar 26, 2020 · 0 comments · Fixed by #15133
Assignees
@brbrr
Labels
[Block] OpenTable [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.4

Comments

@brbrr
Copy link
Contributor

brbrr commented Mar 26, 2020

Steps to reproduce the issue

  1. publish a post with a non-configured OpenTable block
  2. See errors
Notice: Undefined index: rid in /srv/users/user1d1f794a/apps/user1d1f794a/public/wp-content/plugins/jetpack-dev/extensions/blocks/opentable/opentable.php on line 97

Warning: count(): Parameter must be an array or an object that implements Countable in /srv/users/user1d1f794a/apps/user1d1f794a/public/wp-content/plugins/jetpack-dev/extensions/blocks/opentable/opentable.php on line 97
@brbrr brbrr added [Type] Bug When a feature is broken and / or not performing as intended [Block] OpenTable labels Mar 26, 2020
@brbrr brbrr added this to the 8.4 milestone Mar 26, 2020
@brbrr brbrr mentioned this issue Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brbrr brbrr

Labels
[Block] OpenTable [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging a pull request may close this issue.

OpenTable Block: fix possible warning when rid key is not defined Automattic/jetpack
1 participant
@brbrr