Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow & Tiled gallery blocks: Error uploading additional images #14457

Closed
chriskmnds opened this issue Jan 24, 2020 · 5 comments · Fixed by #14651
Closed

Slideshow & Tiled gallery blocks: Error uploading additional images #14457

chriskmnds opened this issue Jan 24, 2020 · 5 comments · Fixed by #14651
Assignees
Labels
[Block] Slideshow [Block] Tiled Gallery Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@chriskmnds
Copy link
Contributor

chriskmnds commented Jan 24, 2020

I notice an error when uploading a second image to the Jetpack -> Slideshow block. This happens on WPCOM in both Gutenberg 7.2.0 (prod) and 7.3.0 (edge) to me.

Steps to reproduce the issue

  1. Go to a block-editor post
  2. Click on the block inserter and add a Jetpack -> Slideshow block
  3. Click to upload an image (should work as expected)
  4. Click to upload another image (should show error in console)

What I expected

Upload a second image to the slideshow.

What happened instead

Error.

Screenshots
If applicable, add screenshots to help explain your problem.

Kapture 2020-01-24 at 11 58 10

Uncaught TypeError: Object(...) is not a function
    at t.addFiles (editor-beta.js?m=1579787284h&ver=wpcom:2)
    at editor-beta.js?m=1579787284h&ver=wpcom:2
    ...

CC @ockham

@chriskmnds chriskmnds added the [Type] Bug When a feature is broken and / or not performing as intended label Jan 24, 2020
@jeherve jeherve added [Block] Slideshow [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Jan 24, 2020
@jeherve
Copy link
Member

jeherve commented Jan 24, 2020

This can also be reproduced in current Jetpack stable without the Gutenberg plugin.

As a workaround, I was able to upload a new image using the Edit pencil icon for the block.

@jeherve jeherve changed the title WPCOM: Error uploading images to Slideshow Slideshow Block: Error uploading additional images Jan 24, 2020
@jeherve
Copy link
Member

jeherve commented Jan 29, 2020

This also impacts the Tiled Gallery block as reported in #14508 by @bindlegirl (good catch!).

2664014-zen

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jan 29, 2020
@kriskarkoski
Copy link

Drag and drop uploading also appears to be broken I suspect by the same issue. It opens the image in the same tab instead of uploading.

@simison simison changed the title Slideshow Block: Error uploading additional images Slideshow & Tiled gallery blocks: Error uploading additional images Feb 3, 2020
@tijosh
Copy link

tijosh commented Feb 3, 2020

Another report of this in #18016187-hc

@jeherve jeherve added this to the 8.3 milestone Feb 10, 2020
@simison
Copy link
Member

simison commented Feb 12, 2020

Looking at core gallery block might reveal what changes are needed. Some of the tiled gallery is modeled after that block so copying the file upload methods over might be good.

@pablinos mentioned on Slack that he could look into this at some point (p1581493933212600-slack-explorers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Slideshow [Block] Tiled Gallery Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants