Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventbrite/Pinterest Blocks: Extract resolveRedirect as shared utility function #14439

Closed
Copons opened this issue Jan 23, 2020 · 2 comments · Fixed by #15218
Closed

Eventbrite/Pinterest Blocks: Extract resolveRedirect as shared utility function #14439

Copons opened this issue Jan 23, 2020 · 2 comments · Fixed by #15218

Comments

@Copons
Copy link
Contributor

Copons commented Jan 23, 2020

As a follow up to #14075 (see also #14075 (comment)), we should extract the resolveRedirect and resolveUrl functions, respectively from the Pinterest and Eventbrite blocks, and move them into a single shared utility function.

@creativecoder
Copy link
Contributor

Note that the Calendly block now uses the resolve-redirect endpoint as well.

@Copons
Copy link
Contributor Author

Copons commented Mar 7, 2020

In #14814 I've created a new testEmbedUrl that should make using resolve-redirect simpler.

See longer description: #14814 (comment)

#14814 adds it to Calendly. I'll take care of Eventbrite and Pinterest once the function is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants