Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling update on Chrome, makes the update "stuck" #140

Closed
psrpinto opened this issue Nov 28, 2022 · 2 comments
Closed

Cancelling update on Chrome, makes the update "stuck" #140

psrpinto opened this issue Nov 28, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@psrpinto
Copy link
Member

On Chrome, clicking the Cancel button in the update dialog, causes the update to be "stuck". Refreshing the page causes the update dialog to be shown again, but clicking Update does not actually update it. Refreshing the page again, shows the update dialog again, indefinitely.

The problem is caused by the service worker not passing from waiting to active state, as is seen in the Chrome Dev Tools:

Screenshot 2022-11-28 at 18 17 27

On Firefox this works correctly.

@psrpinto psrpinto added the bug Something isn't working label Nov 28, 2022
@psrpinto psrpinto added this to the 0.4.0 - Beta milestone Nov 28, 2022
@psrpinto psrpinto mentioned this issue Nov 28, 2022
@psrpinto
Copy link
Member Author

It's possible this issue is also present on hydrogen. If that's the case, the fix should be submitted upstream.

@psrpinto psrpinto self-assigned this Nov 29, 2022
@psrpinto
Copy link
Member Author

I can no longer reproduce this issue. Tested multiple times and service worker upgrade works correctly after cancelling once, or cancelling multiple times in arrow. Issue can be considered resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant